Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicles can be followed by ghosts #4904

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

Doubleumc
Copy link
Contributor

@Doubleumc Doubleumc commented Nov 12, 2023

About the pull request

Loosens the type restrictions on what a ghost can orbit from mob to atom/movable, allowing vehicles to be orbited again. Doesn't effect ghosts viewing player UIs as that is still guarded by an ishuman() check.

Explain why it's good for the game

Vehicles are listed in a ghost's "Follow" menu but clicking them does nothing. This PR allows the ghost to follow the vehicle, as expected.

Testing Photographs and Procedure

Screenshots & Videos

image

image

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: vehicles can be followed by ghosts
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Nov 12, 2023
code/modules/mob/dead/observer/observer.dm Outdated Show resolved Hide resolved
@Doubleumc Doubleumc requested a review from fira November 12, 2023 21:28
@harryob harryob added this pull request to the merge queue Nov 16, 2023
Merged via the queue into cmss13-devs:master with commit 5d8f695 Nov 16, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Nov 16, 2023
@Doubleumc Doubleumc deleted the vehicle-observe branch November 16, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants